Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import-analysis): escape quotes #9729

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 18, 2022

Description

During import analysis which replaces import urls, properly escape quotes.

Ref withastro/astro#4373

Additional context

I feel like there are more places within importAnalysis.ts where we're not properly escaping quotes, but I think we can also fix them as we go.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Aug 18, 2022
@patak-dev patak-dev merged commit 21515f1 into main Aug 18, 2022
@patak-dev patak-dev deleted the fix-import-analysis-quote branch August 18, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants