Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use server.ssrTransform #9769

Merged
merged 1 commit into from
Aug 20, 2022
Merged

refactor: use server.ssrTransform #9769

merged 1 commit into from
Aug 20, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 20, 2022

Description

I am investigating the potential perf improvements of Vitest, and found that ssrTransform is taking a lot of time since it runs full AST parsing in JS for all modules. I am experimenting with a native port for this transformation to speed it up. This PR allows to swap the ssrTransform logic by replacing server.ssrTransform in a plugin and make the experiment testing outside of Vite core. (/cc @patak-dev)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this PR, with the caveats that Vite isn't proposing that overridden the server ssrTransform function is a supported feature. If we end up with a plugin approach, we should have a proper config option in the future. But at least this will unblock you to experiment out of core as you suggest.

@patak-dev patak-dev merged commit 246a087 into main Aug 20, 2022
@patak-dev patak-dev deleted the refactor/ssr-transform branch August 20, 2022 17:39
@patak-dev patak-dev added feat: ssr p3-significant High priority enhancement (priority) labels Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants