Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: delete unused sharding_column_name and sharding_column_type #10378

Closed
deepthi opened this issue May 28, 2022 · 0 comments · Fixed by #10409
Closed

Task: delete unused sharding_column_name and sharding_column_type #10378

deepthi opened this issue May 28, 2022 · 0 comments · Fixed by #10409
Assignees
@arvind-murty
Labels
Type: Internal Cleanup

Comments

@deepthi
Copy link
Member

deepthi commented May 28, 2022

Question

Keyspace protobuf definition still contains sharding_column_name and sharding_column_type. These are from v2 resharding which predates vindex based resharding. These fields can now be removed.
@deepthi deepthi added Type: Question Needs Triage This issue needs to be correctly labelled and triaged Type: Internal Cleanup and removed Type: Question Needs Triage This issue needs to be correctly labelled and triaged labels May 28, 2022
@arvind-murty arvind-murty mentioned this issue Jun 1, 2022
Merged
3 tasks
This was referenced Jun 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arvind-murty arvind-murty

Labels
Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove v2 resharding fields arvind-murty/vitess
2 participants
@deepthi @arvind-murty