-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: support throttling on "any" cell by default in vttablet transaction throttler #12435
Comments
@timvaillancourt are you suggesting |
@harshit-gangal I mean all cells available to the For example: if deployed in a cluster with cells Today the transaction throttler will fail to start unless an explicit list of cells is provided, even if you just want "all available" |
I like this. Thank you for clarifying. |
@harshit-gangal thanks! I think it's more in line with how A PR has been created to implement this: #12477 |
I'm also in agreement this should be the solution. |
Feature Description
Currently the
vttablet
transaction throttler will not start if the list of cells to healthcheck is not defined. This scenario also causes the transaction throttler to be somewhat-silently disabled, which is another issue I reported hereAn example:
When no
-tx-throttler-healthcheck-cells
is specified I suggestvttablet
uses all available cells instead of refusing to start the transaction throttlerI am happy to make a PR implementing what is decided here 👍. If we decide to leave this as-is, I feel more could be done to highlight that
-tx-throttler-healthcheck-cells
is a required flag when using-enable-tx-throttler
Use Case(s)
A fallback to "any cell" simplifies deployment/config automation for some users who today need to define an exhaustive list of cells to monitor. Users without a preference on cells to monitor can simply not-define this flag.
To me, this seems like the more intuitive default as well.
The text was updated successfully, but these errors were encountered: