Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: CheckThrottler log entries too noisy #13924

Closed
shlomi-noach opened this issue Sep 6, 2023 · 0 comments · Fixed by #13925
Closed

Bug Report: CheckThrottler log entries too noisy #13924

shlomi-noach opened this issue Sep 6, 2023 · 0 comments · Fixed by #13925

Comments

@shlomi-noach
Copy link
Contributor

Overview of the Issue

In response to a CheckThrottler request, we invoke:

defer s.tm.HandleRPCPanic(ctx, "CheckThrottler", request, response, true /*verbose*/, &err)

with verbose=true, which logs an entry whether there's an error or not. It makes sense to audit most gRPC calls, but not this call, since it's being invoked multiple times per second.

We should silence these message.

Reproduction Steps

Binary Version

`main`, post `release-17.0`

Operating System and Environment details

-

Log Fragments

No response

@shlomi-noach shlomi-noach added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged labels Sep 6, 2023
@shlomi-noach shlomi-noach self-assigned this Sep 6, 2023
@shlomi-noach shlomi-noach added Component: Throttler and removed Needs Triage This issue needs to be correctly labelled and triaged labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant