Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablet throttler: post-v18 changes #14180

Closed
4 tasks
shlomi-noach opened this issue Oct 4, 2023 · 0 comments · Fixed by #14181
Closed
4 tasks

Tablet throttler: post-v18 changes #14180

shlomi-noach opened this issue Oct 4, 2023 · 0 comments · Fixed by #14181
Labels
Component: Throttler Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Internal Cleanup

Comments

@shlomi-noach
Copy link
Contributor

Followup to #13341

v18 RC1 is released, and the following should be done for v19:

  • v18 added gRPC inter-checks, with fallback to HTTP for backwards compatibility. v19 should drop that compatibility and completely remove HTTP checks.
  • This calls for a refactor of the throttler, removing all InstanceKey references, any hostname:port use. All access should be done by tablet alias or tablet reference.
  • A long time coming, while the throttler was tested in the past releases via endtoend tests (and extensively so), it did not enjoy proper unit/race tests. These should now be added.
  • A few other minor updates to the throttler code are in place, such as adapting to recent golang atomic types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Throttler Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Internal Cleanup
Projects
None yet
1 participant