Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoveTables Create: ensure that none of the tables to be moved have data #16817

Closed
rohit-nayak-ps opened this issue Sep 21, 2024 · 4 comments
Closed

MoveTables Create: ensure that none of the tables to be moved have data #16817

rohit-nayak-ps opened this issue Sep 21, 2024 · 4 comments
Assignees
@mattlord @beingnoble03
Labels
Component: VReplication Type: Feature

Comments

@rohit-nayak-ps
Copy link
Contributor

Feature Description

When a MoveTables workflow is created, error out if any of the tables (if they exist) have any data.

Use Case(s)

It is possible by mistake to create two workflows for the same set of tables, or select All Tables after some of the tables have been moved. Currently it fails with a duplicate key error after the workflow is created. We should bail out right at Create
@mattlord
Copy link
Contributor

mattlord commented Sep 22, 2024 •
edited
Loading

Just FYI: https://github.com/vitessio/vitess/pull/16810/files#diff-1e25101181c9311c90765891b1cea65cc520227bf4d35f3ad0421d1077ea9de5R280-R299

@mattlord mattlord mentioned this issue Sep 23, 2024
Merged
5 tasks
@mattlord mattlord self-assigned this Sep 23, 2024
@beingnoble03 beingnoble03 mentioned this issue Sep 23, 2024
Closed
5 tasks
@rohit-nayak-ps
Copy link
Contributor Author

Incorrectly marked as fixed in #16810

@mattlord
Copy link
Contributor

Incorrectly marked as fixed in #16810

Whoops. Sorry about that. I've updated the description to remove it.

@beingnoble03 beingnoble03 mentioned this issue Oct 2, 2024
Merged
5 tasks
@rohit-nayak-ps
Copy link
Contributor Author

Closed via #16874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattlord mattlord

@beingnoble03 beingnoble03

Labels
Component: VReplication Type: Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattlord @rohit-nayak-ps @beingnoble03