Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: vtorc to support --topo_read_concurrency limit #17073

Open
timvaillancourt opened this issue Oct 25, 2024 · 0 comments · May be fixed by #17071
Open

Feature Request: vtorc to support --topo_read_concurrency limit #17073

timvaillancourt opened this issue Oct 25, 2024 · 0 comments · May be fixed by #17071
Assignees
@timvaillancourt
Labels
Component: VTorc Vitess Orchestrator integration Type: Performance

Comments

@timvaillancourt
Copy link
Contributor

Feature Description

This issue requests VTOrc supports and respects the --topo_read_concurrency flag that several other Vitess components support, but not VTOrc

Today (v21) VTOrc is creating a new, unbounded goroutine for each tablet it wants to fetch from the topo which leads to some inefficiencies and a large number of unbounded network connections to the topo

The fix for this is implemented in #17071

Use Case(s)

Regular VTOrc users
@timvaillancourt timvaillancourt added Type: Performance Component: VTorc Vitess Orchestrator integration labels Oct 25, 2024
@timvaillancourt timvaillancourt self-assigned this Oct 25, 2024
@timvaillancourt timvaillancourt linked a pull request Oct 25, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timvaillancourt timvaillancourt

Labels
Component: VTorc Vitess Orchestrator integration Type: Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve efficiency of vtorc topo calls timvaillancourt/vitess
1 participant
@timvaillancourt