-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomic Transactions correctness with PRS, ERS and MySQL & Vttablet Restarts #16553
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…ed atomic Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…the same column with extra information Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
… ers and mysql restarts secure Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16553 +/- ##
=======================================
Coverage 68.87% 68.88%
=======================================
Files 1562 1562
Lines 200621 200673 +52
=======================================
+ Hits 138183 138231 +48
- Misses 62438 62442 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good.
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…starts (vitessio#16553) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
Description
This PR makes the code changes required to ensure that atomic transactions don't break their atomic guarantee in the face of disruptions like
PlannedReparentShard
,EmergencyReparentShard
, and MySQL and Vttablet restarts.A lot of the logic on how we redo the prepared transactions had to be reworked. This PR also adds the design docs for these changes so that they can referenced in the future too.
The testing strategy for ensuring these changes work as intended is 2-fold -
This PR also adds a new design doc explaining all the steps that are involved in guaranteeing that atomic transactions work well with each of the many disruptions
Related Issue(s)
Checklist
Deployment Notes