Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject atomic distributed transaction on a network connection #16584

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Aug 12, 2024

Description

This PR rejects distributed transactions prepared when carried on a non-unix socket connection.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal harshit-gangal changed the title reject prepare on a network connection reject atomic distributed transaction on a network connection Aug 12, 2024
@harshit-gangal harshit-gangal changed the title reject atomic distributed transaction on a network connection Reject atomic distributed transaction on a network connection Aug 12, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 12, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (61959f6) to head (3f0b9b8).
Report is 7 commits behind head on main.

Files Patch % Lines
go/vt/vttest/local_cluster.go 0.00% 7 Missing ⚠️
go/vt/vttablet/tabletserver/dt_executor.go 33.33% 2 Missing ⚠️
go/vt/vttablet/tabletserver/stateful_connection.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16584      +/-   ##
==========================================
+ Coverage   68.77%   68.83%   +0.05%     
==========================================
  Files        1557     1557              
  Lines      199891   199949      +58     
==========================================
+ Hits       137483   137630     +147     
+ Misses      62408    62319      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshit Gangal <[email protected]>
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purrfect 🚀

@harshit-gangal harshit-gangal merged commit 0d6b768 into vitessio:main Aug 16, 2024
129 checks passed
@harshit-gangal harshit-gangal deleted the dx-unixsocket branch August 16, 2024 09:23
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants