-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Join using Values Statement #16703
base: main
Are you sure you want to change the base?
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16703 +/- ##
==========================================
- Coverage 68.93% 68.87% -0.07%
==========================================
Files 1564 1566 +2
Lines 201371 201695 +324
==========================================
+ Hits 138821 138916 +95
- Misses 62550 62779 +229 ☔ View full report in Codecov by Sentry. |
5f5d698
to
9fe7f3f
Compare
9cfbb29
to
4934151
Compare
@@ -123,6 +125,14 @@ func runRewriters(ctx *plancontext.PlanningContext, root Operator) Operator { | |||
} | |||
|
|||
func tryConvertApplyToValuesJoin(ctx *plancontext.PlanningContext, in *ApplyJoin) (Operator, *ApplyResult) { | |||
ok, err := capabilities.MySQLVersionHasCapability(ctx.VSchema.Environment().MySQLVersion(), capabilities.ValuesRow) | |||
if err != nil { | |||
panic(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we just fall back on ApplyJoin
if we are not sure Values
is valid?
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
…le. Added new Row_Tuple bind variable type for formatting in vttablet Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
… form and stay there Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
3908a68
to
31a48fb
Compare
Description
Related Issue(s)
Implements #16508
Checklist
Deployment Notes