-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChangeTabletTags
RPC to vtctl
, ChangeTags
RPC to vttablet
#16857
Draft
timvaillancourt
wants to merge
2
commits into
vitessio:main
Choose a base branch
from
timvaillancourt:changeTabletTagsRPC
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add ChangeTabletTags
RPC to vtctl
, ChangeTags
RPC to vttablet
#16857
timvaillancourt
wants to merge
2
commits into
vitessio:main
from
timvaillancourt:changeTabletTagsRPC
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvaillancourt
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: vtctl
Component: VTTablet
labels
Sep 27, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Sep 27, 2024
timvaillancourt
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Sep 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16857 +/- ##
==========================================
- Coverage 69.43% 69.42% -0.02%
==========================================
Files 1571 1571
Lines 203021 203238 +217
==========================================
+ Hits 140970 141093 +123
- Misses 62051 62145 +94 ☔ View full report in Codecov by Sentry. |
timvaillancourt
force-pushed
the
changeTabletTagsRPC
branch
2 times, most recently
from
September 27, 2024 20:17
edd1cb9
to
c6d7eca
Compare
Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt
force-pushed
the
changeTabletTagsRPC
branch
from
September 27, 2024 20:28
e2ba0df
to
03a26d1
Compare
Signed-off-by: Tim Vaillancourt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: vtctl
Component: VTTablet
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #16377, this PR implements a new
vtctld
and correspondingvttablet
RPC to allow the tags of a tablet to be changedChangeTabletTags
ChangeTags
The new RPC supports both replacing and merging the existing tags. This merging happens on the tablet under a lock
CLI
Related Issue(s)
#16377
Checklist
Deployment Notes