From 4966399ee3f6280f893cf8204e36d55b26c8258c Mon Sep 17 00:00:00 2001 From: Nguyen Hai Truong Date: Wed, 13 Feb 2019 20:03:55 -0800 Subject: [PATCH] Fix small errors There are many wrong typos that need to be fixed. Signed-off-by: Nguyen Hai Truong --- doc/Contributing.md | 2 +- doc/DesignDocs.md | 2 +- doc/HorizontalReshardingWorkflowGuide.md | 2 +- doc/SeparatingVttabletMysql.md | 2 +- doc/Upgrading.md | 2 +- go/vt/proto/query/query.pb.go | 2 +- proto/query.proto | 2 +- test/initial_sharding.py | 2 +- test/legacy_resharding.py | 2 +- test/merge_sharding.py | 2 +- test/resharding.py | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/doc/Contributing.md b/doc/Contributing.md index a5a116e9322..5c49727a920 100644 --- a/doc/Contributing.md +++ b/doc/Contributing.md @@ -34,7 +34,7 @@ A readability reviewer ensures that the reviewee is writing idiomatic code and f While there's no Go style guide, there is a set of recommendations in the Go community which add up to an implicit style guide. To make sure you're writing idiomatic Go code, please read the following documents: -* Go Readablity slides: https://talks.golang.org/2014/readability.slide +* Go Readability slides: https://talks.golang.org/2014/readability.slide * Talk about Go readability with many specific examples. * "Effective Go": https://golang.org/doc/effective_go.html * Recommendations for writing good Go code. diff --git a/doc/DesignDocs.md b/doc/DesignDocs.md index 748e83b15a3..f4d06fa0f59 100644 --- a/doc/DesignDocs.md +++ b/doc/DesignDocs.md @@ -2,4 +2,4 @@ The pages below this navigation entry "Design Docs" represent the design conside that went behind some of the features implemented. They may not be necessarily up-to-date. Also, some of the ideas here may just be experimental proposals, and it's possible -that such ideas might have been abandonned or not implemented yet. +that such ideas might have been abandoned or not implemented yet. diff --git a/doc/HorizontalReshardingWorkflowGuide.md b/doc/HorizontalReshardingWorkflowGuide.md index a287e194664..ff3eb8b0809 100644 --- a/doc/HorizontalReshardingWorkflowGuide.md +++ b/doc/HorizontalReshardingWorkflowGuide.md @@ -142,7 +142,7 @@ workflow. A "Retry" button will be enabled under the task node if the task failed (click the task node if your job get stuck but don't see the Retry button). Click this button if you have fixed the bugs and want to retry the failed task. You can -retry as many times as you want if the task continuelly failed. The workflow +retry as many times as you want if the task continually failed. The workflow can continue from your failure point once it is fixed. For example, you might forget to bring up a vtworker process. The task which diff --git a/doc/SeparatingVttabletMysql.md b/doc/SeparatingVttabletMysql.md index 0ddaeecdfa8..e98e610517f 100644 --- a/doc/SeparatingVttabletMysql.md +++ b/doc/SeparatingVttabletMysql.md @@ -26,7 +26,7 @@ The following adjustments need to be made to VTTablet command line parameters: * Disable restores / backups, by not passing any backup command line parameters. Specifically, `-restore_from_backup` and - `-backup_storage_implementation` shoud not be set. + `-backup_storage_implementation` should not be set. Since master management and replication are not handled by Vitess, we just need to make sure the tablet type in the topology is correct before running diff --git a/doc/Upgrading.md b/doc/Upgrading.md index 625c61aaafa..f9acb603760 100644 --- a/doc/Upgrading.md +++ b/doc/Upgrading.md @@ -26,7 +26,7 @@ Please use this upgrade order (unless otherwise noted in the release notes): - vtgate - application code which links client libraries -*vtctld* is listed first to make sure that you can still adminstrate Vitess - or if not find out as soon as possible. +*vtctld* is listed first to make sure that you can still administrate Vitess - or if not find out as soon as possible. ## Canary Testing diff --git a/go/vt/proto/query/query.pb.go b/go/vt/proto/query/query.pb.go index 34f04da29f9..f821d65e994 100644 --- a/go/vt/proto/query/query.pb.go +++ b/go/vt/proto/query/query.pb.go @@ -854,7 +854,7 @@ type ExecuteOptions struct { // vitess also sets a rowcount limit on queries, the smallest value wins. SqlSelectLimit int64 `protobuf:"varint,8,opt,name=sql_select_limit,json=sqlSelectLimit,proto3" json:"sql_select_limit,omitempty"` TransactionIsolation ExecuteOptions_TransactionIsolation `protobuf:"varint,9,opt,name=transaction_isolation,json=transactionIsolation,proto3,enum=query.ExecuteOptions_TransactionIsolation" json:"transaction_isolation,omitempty"` - // skip_query_plan_cache specifies if the query plan shoud be cached by vitess. + // skip_query_plan_cache specifies if the query plan should be cached by vitess. // By default all query plans are cached. SkipQueryPlanCache bool `protobuf:"varint,10,opt,name=skip_query_plan_cache,json=skipQueryPlanCache,proto3" json:"skip_query_plan_cache,omitempty"` XXX_NoUnkeyedLiteral struct{} `json:"-"` diff --git a/proto/query.proto b/proto/query.proto index 53525325378..5fdb91d4ed9 100644 --- a/proto/query.proto +++ b/proto/query.proto @@ -296,7 +296,7 @@ message ExecuteOptions { TransactionIsolation transaction_isolation = 9; - // skip_query_plan_cache specifies if the query plan shoud be cached by vitess. + // skip_query_plan_cache specifies if the query plan should be cached by vitess. // By default all query plans are cached. bool skip_query_plan_cache = 10; } diff --git a/test/initial_sharding.py b/test/initial_sharding.py index cb4fb3428b7..5c639def51b 100755 --- a/test/initial_sharding.py +++ b/test/initial_sharding.py @@ -631,7 +631,7 @@ def test_resharding(self): utils.run_vtctl(['DeleteTablet', '-allow_master', shard_master.tablet_alias], auto_log=True) - # rebuild the serving graph, all mentions of the old shards shoud be gone + # rebuild the serving graph, all mentions of the old shards should be gone utils.run_vtctl(['RebuildKeyspaceGraph', 'test_keyspace'], auto_log=True) # delete the original shard diff --git a/test/legacy_resharding.py b/test/legacy_resharding.py index 4f0ecd41998..9e57261507d 100755 --- a/test/legacy_resharding.py +++ b/test/legacy_resharding.py @@ -622,7 +622,7 @@ def test_resharding(self): utils.run_vtctl(['DeleteTablet', '-allow_master', shard_1_master.tablet_alias], auto_log=True) - # rebuild the serving graph, all mentions of the old shards shoud be gone + # rebuild the serving graph, all mentions of the old shards should be gone utils.run_vtctl( ['RebuildKeyspaceGraph', 'test_keyspace'], auto_log=True) diff --git a/test/merge_sharding.py b/test/merge_sharding.py index 72e71e4dbfd..8a424b4bd0c 100755 --- a/test/merge_sharding.py +++ b/test/merge_sharding.py @@ -452,7 +452,7 @@ def test_merge_sharding(self): utils.run_vtctl(['DeleteShard', 'test_keyspace/-40'], auto_log=True) utils.run_vtctl(['DeleteShard', 'test_keyspace/40-80'], auto_log=True) - # rebuild the serving graph, all mentions of the old shards shoud be gone + # rebuild the serving graph, all mentions of the old shards should be gone utils.run_vtctl(['RebuildKeyspaceGraph', 'test_keyspace'], auto_log=True) # kill everything else diff --git a/test/resharding.py b/test/resharding.py index a942c6dd466..39010a8c51c 100755 --- a/test/resharding.py +++ b/test/resharding.py @@ -1214,7 +1214,7 @@ def test_resharding(self): utils.run_vtctl(['DeleteTablet', '-allow_master', shard_1_master.tablet_alias], auto_log=True) - # rebuild the serving graph, all mentions of the old shards shoud be gone + # rebuild the serving graph, all mentions of the old shards should be gone utils.run_vtctl( ['RebuildKeyspaceGraph', 'test_keyspace'], auto_log=True)