From 69f128d60c4afe5cbee40c502d4014fd20357435 Mon Sep 17 00:00:00 2001 From: Michael Demmer Date: Tue, 26 Feb 2019 22:17:56 -0800 Subject: [PATCH] properly use sqlparser.String to quote reserved table names Signed-off-by: Michael Demmer --- go/vt/vtexplain/vtexplain_vttablet.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/go/vt/vtexplain/vtexplain_vttablet.go b/go/vt/vtexplain/vtexplain_vttablet.go index 64d9ed55470..e30727da8b5 100644 --- a/go/vt/vtexplain/vtexplain_vttablet.go +++ b/go/vt/vtexplain/vtexplain_vttablet.go @@ -388,7 +388,7 @@ func initTabletEnvironment(ddls []*sqlparser.DDL, opts *Options) error { } for i, ddl := range ddls { - table := ddl.Table.Name.String() + table := sqlparser.String(ddl.Table.Name) schemaQueries[mysql.BaseShowTablesForTable(table)] = &sqltypes.Result{ Fields: mysql.BaseShowTablesFields, RowsAffected: 1, @@ -511,9 +511,10 @@ func (t *explainTablet) HandleQuery(c *mysql.Conn, query string, callback func(* return callback(&sqltypes.Result{}) } - colTypeMap := tableColumns[table.String()] - if colTypeMap == nil && table.String() != "dual" { - return fmt.Errorf("unable to resolve table name %s", table.String()) + tableName := sqlparser.String(table) + colTypeMap := tableColumns[tableName] + if colTypeMap == nil && tableName != "dual" { + return fmt.Errorf("unable to resolve table name %s", tableName) } colNames := make([]string, 0, 4)