Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mermaid diagrams getting cropped and sized incorrectly #178

Closed
ivan-danilov opened this issue Feb 20, 2019 · 7 comments
Closed

mermaid diagrams getting cropped and sized incorrectly #178

ivan-danilov opened this issue Feb 20, 2019 · 7 comments
Assignees
Labels

Comments

@ivan-danilov
Copy link

I have cropping on my diagrams that does not happen with the last mermaid version (8.0.0) at the time.

I can make a PR with updated/minified mermaid.js if needed.

@Pilskalns
Copy link

Hi @ivan-danilov,

So you did local mermaid update and that solved the issues? As I am not familiar with the mermaid, could you do also test updated version in different scenarios before doing PR?

Other than that, would be nice to see your PR :)

@ivan-danilov
Copy link
Author

Hi @Pilskalns
See the PR above. I looked at it through my couple dozens of diagrams. Are there other ways I can test the version?

Maybe nice to add some diagram examples to the example site, what do you think?

@ivan-danilov ivan-danilov changed the title Upgrade mermaid mermaid diagrams getting cropped and sized incorrectly Feb 21, 2019
@Pilskalns
Copy link

Yes, adding docs examples would be cool. Please add to the PR. They are (and will) be built in this unique PR preview URL. So you can test how they will work on production. The link is also available when expanding checks section at PR page.

@ivan-danilov
Copy link
Author

In fact, there are some examples in the shortcodes section (for preview URL it is here). Totally missed them and they seem to work fine.

@ivan-danilov
Copy link
Author

Added some more complicated example of a flowchart. Take a look, seems to render correctly.

@ivan-danilov
Copy link
Author

I'm also trying to put another PR into mermaid here mermaid-js/mermaid#798

Just in case, I added another commit that updates mermaid.js once again with that PR included along with an example on the exampleSite. Hopefully, it will be useful as well.

@Pilskalns
Copy link

I've merged this into master with squash. You will have to pull again to avoid conflicts.

Thanks @ivan-danilov for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants