-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mermaid diagrams getting cropped and sized incorrectly #178
Comments
Hi @ivan-danilov, So you did local mermaid update and that solved the issues? As I am not familiar with the mermaid, could you do also test updated version in different scenarios before doing PR? Other than that, would be nice to see your PR :) |
Hi @Pilskalns Maybe nice to add some diagram examples to the example site, what do you think? |
Yes, adding docs examples would be cool. Please add to the PR. They are (and will) be built in this unique PR preview URL. So you can test how they will work on production. The link is also available when expanding checks section at PR page. |
In fact, there are some examples in the shortcodes section (for preview URL it is here). Totally missed them and they seem to work fine. |
Added some more complicated example of a flowchart. Take a look, seems to render correctly. |
I'm also trying to put another PR into mermaid here mermaid-js/mermaid#798 Just in case, I added another commit that updates mermaid.js once again with that PR included along with an example on the exampleSite. Hopefully, it will be useful as well. |
I've merged this into master with squash. You will have to pull again to avoid conflicts. Thanks @ivan-danilov for your contribution! |
I have cropping on my diagrams that does not happen with the last mermaid version (8.0.0) at the time.
I can make a PR with updated/minified mermaid.js if needed.
The text was updated successfully, but these errors were encountered: