Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Stylized progress bar for all samplers #935

Closed
diniamo opened this issue May 14, 2023 · 2 comments
Closed

[Issue]: Stylized progress bar for all samplers #935

diniamo opened this issue May 14, 2023 · 2 comments

Comments

@diniamo
Copy link

diniamo commented May 14, 2023

Issue Description

The only sampler that has a stylized progress bar (console) is UniPC, and it's also the only one I could find the code of. If this is not something that anyone wants to work on, can I at least have a pointer as to where the progress bar logic is handled?

On an unrelated note, why is UniPC the default sampler in SD.Next? I couldn't find any information on that.

image
(top: UniPC, bottom: Euler a (or any other))

Version Platform Description

Version: 926b866
Arch Linux, Kitty terminal (also happens to my friend who uses Windows Terminal)

@vladmandic
Copy link
Owner

all other samplers come from external code, either compvis (ddim and plms) or k-diffusers (all others). modifying progress bar would be trivial, but that would mean that code would not be in sync with upstream and no automatic updates would be possible.

unipc is the only diffuser that is natively built inside this repo, so i can do those enhancements.
why is it default? because its not bad and its really fast. something has to be default, so why not unipc?

and why is this created as an issue? its a valid question, but far better suited for discussions.

@diniamo
Copy link
Author

diniamo commented May 14, 2023

That's because I didn't know Github discussions existed, thank you for pointing that out and for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants