Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: microsoft/Phi-3-vision-128k-instruct Vision support #4958

Closed
pseudotensor opened this issue May 21, 2024 · 1 comment · Fixed by #4986
Closed

[Feature]: microsoft/Phi-3-vision-128k-instruct Vision support #4958

pseudotensor opened this issue May 21, 2024 · 1 comment · Fixed by #4986

Comments

@pseudotensor
Copy link

pseudotensor commented May 21, 2024

🚀 The feature, motivation and pitch

https://huggingface.co/microsoft/Phi-3-vision-128k-instruct

Alternatives

No response

Additional context

vllm is somewhat behind in vision support. idefics2 is supported by TGI and lllava next been out for months and not supported yet. There is a PR, is it close?

@Isotr0py
Copy link
Collaborator

The vllm's multi-modality support is still under refactoring:

So we need waiting some necessary refactoring work (like ImageProcessor support) finished before we add new vision model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants