🦂 [Bug]Diremaul

[ShiyoKozuki]

🦂 Bug report - Dungeon

Captain Kromcrush gives quest before you finish tribute run
Knot Thimblejack's Cache did not spawn after freeing him
Guard Slip'kik does not give buff after tribute run

Expected behavior

https://www.wowhead.com/classic/guide/dire-maul-north-dungeon-strategy-wow-classic
https://www.icy-veins.com/wow-classic/dire-maul-north-dungeon-guide
captain kromcrush shouldn't quest before you finish tribute run
Knot Thimblejack's Cache should spawn after freeing him
Guard Slip'kik should give buff after tribute run

Version & Environment

Client Version: 1.12.1

Commit Hash:
https://github.com/ShiyoKozuki/core

Don't know what this means but this is my repo

[mserajnik]

Don't know what this means but this is my repo

Commit hash means that you would specify the commit that you were at when you built the server, e.g., 7836306.

This is done so that it can be determined if a bug was fixed (or maybe also introduced) with a newer commit than what you are using (also going forward in time, so it’s useful to state the explicit commit instead of just “latest” because it won’t be the latest in half a year anymore).

You’ll generally not get support here though if you are building the server from a different repository than this official one (from what I’ve observed), so you should verify that the bug also exists when building the server from the latest commit in this repository.

[ShiyoKozuki]

Don't know what this means but this is my repo

Commit hash means that you would specify the commit that you were at when you built the server, e.g., 7836306.

This is done so that it can be determined if a bug was fixed (or maybe also introduced) with a newer commit than what you are using (also going forward in time, so it’s useful to state the explicit commit instead of just “latest” because it won’t be the latest in half a year anymore).

You’ll generally not get support here though if you are building the server from a different repository than this official one (from what I’ve observed), so you should verify that the bug also exists when building the server from the latest commit in this repository.

So this?
ShiyoKozuki@a44cbd6

I build off the core besides some partybot/battlebot ai ive changed and 2 prs(from the official repo)

[mserajnik]

Yeah, you reference a specific commit like that.

And I think it’s more of a general stance that you won’t get support for code from other repos, no matter how large or small the changes compared to the official repo are. So it would still be best to just test if the issue also occurs here, even if the changes in your repo have nothing to do with the issue you are experiencing. But that’s not up to me, I’m just stating what I observed thus far. 🙂

Also, I think two of your issues stated have already been reported, by the way: #2249

[ratkosrb]

You should not report things before having tested them on clean vmangos.