🐛 [Bug] Pet follow movement

[Stoabrogga]

🐛 Bug report

Pets following the player sometimes show strange movement:

• Player stops, the pet stops, too, but does turn around in an endless loop:
  https://github.com/user-attachments/assets/4864e989-04ff-4500-bafa-b0c6134dd41b

• While the player runs into one direction, the pet sometimes "teleports" a short distance:
  https://github.com/user-attachments/assets/7213e1da-7600-4990-95e3-ddf6c597952a

Expected behavior

The pet should smoothly follow the player.

Steps to reproduce

Create a warlock/hunter and watch the pet movement.

Version & Environment

Client Version: 1.12.1.5875
Commit Hash: 9b3b375

OS Client: Ubuntu 22.04 (Wine)
OS Server: Ubuntu 22.04

[Stoabrogga]

The first part is fixed with commit d58f8f6, but I cannot fix the second part. Played around with TargetedMovementGenerator, tried point movement without pathfinding, checked if spline position is different if the creature is still moving, but did not find the cause of those short "teleports" and "hiccups". Perhaps a kind of movement prediction is needed here.

[gajet5]

Could this be related to the problem when pets don't catch up with fleeing mobs?

330263936-5b5d5f74-dd55-47d3-86ff-207cb1b08008.mp4

330263935-207b5fe5-dd6e-4d73-bff4-6f82e3761c96.mp4

[Stoabrogga]

The pet also sometimes makes small "jumps" in the air:
https://github.com/user-attachments/assets/8d3991be-98bd-407e-849f-639eb051195f

Is this only occurring for me?

[Daribon]

The pet also sometimes makes small "jumps" in the air: https://github.com/user-attachments/assets/8d3991be-98bd-407e-849f-639eb051195f

Is this only occurring for me?

Are you using vanillafixes?
Because if you are, very high FPS can cause NPCs to teleport into the air while moving. The higher FPS the more it happens.
Limit framerate to 144 fps (or the hz of your monitor provided it's not a 360hz one) if you use vanillafixes.

[Stoabrogga]

No, I normally use Wine, but I tested this now on 2 PCs and a notebook using Wine with and without VanillaFixes and Windows 10 with and without VanillaFixes. Always the same result. It seems to happen more if the character is fast, e.g. using aura 16618 (Spirit of the Wind).

CMaNGOS uses movement prediction, perhaps something like this can be implemented for VMaNGOS:
https://github.com/cmangos/mangos-classic/blob/master/src/game/MotionGenerators/TargetedMovementGenerator.cpp