Fixing external-dns config for route53 #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for educates-docs canceled.Built without sensitive environment variables
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of external-dns with relation to Route53, as it changed upstream in version 0.13.6 (kubernetes-sigs/external-dns#3695)
This PR will:
--aws-zone-match-parentto support back match parents as fixed by feat(aws-provider): create flag to support sub-domains match parent kubernetes-sigs/external-dns#4236 in 0.14.1--policytosyncso that txt and CNAMEs are deleted on uninstall. Previously we hadupsert-onlywhich left the records there.Fixes #535