Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupRepository (restic) can become stale after bsl recreate #7292

Closed
kaovilai opened this issue Jan 9, 2024 · 3 comments · Fixed by #7380
Closed

backupRepository (restic) can become stale after bsl recreate #7292

kaovilai opened this issue Jan 9, 2024 · 3 comments · Fixed by #7380

Comments

@kaovilai
Copy link
Contributor

kaovilai commented Jan 9, 2024

Similar to #5226 but instead of during update, it was during recreate with the same name but different spec

Fix: if BSL is newer (from creationTimestamp) than BackupRepository, also mark BackupRepository as invalid, extending Issue fix 5226 by Lyndon-Li · Pull Request #5768 · vmware-tanzu/velero (github.com)

Found by @PrasadJoshi12 via https://issues.redhat.com/browse/OADP-3316

@kaovilai
Copy link
Contributor Author

kaovilai commented Jan 9, 2024

You could assign me this issue

@kaovilai
Copy link
Contributor Author

kaovilai commented Jan 9, 2024

perhaps during any bsl create, just go ahead and find related backupRepo and invalidate them to begin with.

@reasonerjt reasonerjt added the Restic Relates to the restic integration label Jan 15, 2024
@reasonerjt reasonerjt assigned reasonerjt and kaovilai and unassigned reasonerjt Jan 15, 2024
@reasonerjt
Copy link
Contributor

cc @Lyndon-Li please also keep an eye to make sure the change won't cause regression on kopia side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants