Set the InventoryPath of the folder object in DefaultFolder #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
reviewed
Jul 3, 2019
find/finder.go
Outdated
| @@ -916,6 +916,13 @@ func (f *Finder) DefaultFolder(ctx context.Context) (*object.Folder, error) { | |||
| } | |||
| folder := object.NewFolder(f.client, ref.Reference()) | |||
|
|
|||
| // Set the InventoryPath of the newly created folder object | |||
| e, err := f.Element(ctx, folder.Reference()) | |||
There was a problem hiding this comment.
In this case, we can avoid calling f.Element, since we have the Datacenter already and the vmFolder name is always "vm". I think the following should be ok:
folder.SetInventoryPath(path.Join(f.dc.Datacenter.InventoryPath, "vm"))Can you try that out?
There was a problem hiding this comment.
I tried this approach and it works. Pushed a new commit with the change.
|
Thanks @ykakarap ! |
dougm
pushed a commit
that referenced
this pull request
Jul 3, 2019
* Set the InventoryPath of the folder object in DefaultFolder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DefaultFolderis called inFolderOrDefaultfunction which is expected to return a folder object of the default folder if the given path the empty.The
DefaultFolderobject after creating the folder object needs to set the InventoryPath.This PR fixes the above-mentioned issue.