Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vsan Performance Data Collection API #2021

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Vsan Performance Data Collection API #2021

merged 5 commits into from
Jul 21, 2020

Conversation

ysobale
Copy link
Contributor

@ysobale ysobale commented Jun 15, 2020

Added VSAN Performance data collection API
#2018

@ysobale ysobale changed the title Vsan perf api Vsan Performance Data Collection API Jun 15, 2020
dougm
dougm reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ysobale , looks good, but let's avoid changing the generated types.go

vsan/types/types.go Outdated Show resolved Hide resolved
dougm
dougm approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ysobale

@dougm dougm merged commit 378a24c into vmware:master Jul 21, 2020
@ysobale
Copy link
Contributor Author

ysobale commented Jul 21, 2020

Thanks @dougm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

@divyenpatel divyenpatel Awaiting requested review from divyenpatel

@BaluDontu BaluDontu Awaiting requested review from BaluDontu

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysobale @dougm @vmwclabot