Add a command line option to change an existing disk attached to a VM #658
Conversation
…. Size and mode only.
|
@bastienbc, VMware has approved your signed contributor license agreement. |
| @@ -0,0 +1,179 @@ | |||
| /* | |||
| Copyright (c) 2014-2015 VMware, Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
Yes, just '2017' is fine here. Everything else looks good @bastienbc
There was a problem hiding this comment.
@bastienbc thanks, looks great, just a few review comments.
| } | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add a 'func (cmd *change) Description() string', the 'Examples' section in particular is most helpful.
| } | ||
| } | ||
|
|
||
| switch { |
There was a problem hiding this comment.
switch len(disks) {
case 0:
...
case 1:
...
default:
}| for _, device := range list { | ||
| switch md := device.(type) { | ||
| case *types.VirtualDisk: | ||
| switch { |
There was a problem hiding this comment.
This looks the same as CheckDiskProperties? If so, personally would prefer to see CheckDiskProperties return a bool and call it here to remove the duplicate code.
|
|
||
| err = task.Wait(ctx) | ||
| if err != nil { | ||
| return errors.New(fmt.Sprintf("Error resizing main disk\nLogged Item: %s", err)) |
There was a problem hiding this comment.
should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (go-golint)
| @@ -0,0 +1,179 @@ | |||
| /* | |||
| Copyright (c) 2014-2015 VMware, Inc. All Rights Reserved. | |||
…e pull request made by dougm.
I needed the ability to resize a VM disk once it has been created, so I made a new command: "vm.disk.change".
It allows search of a disk using its name, label, key or even the file path to the vmdk.
It only changes the size, and the mode.