Add support for cpu + mem allocation to vm.change command #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
force-pushed
the
vm-change-allocation
branch
from
4723e0e
to
2605fac
Compare
|
@embano1 added resource allocation flags to the |
anfernee
reviewed
Nov 10, 2017
| func NewResourceAllocationFlag(cpu, mem *types.ResourceAllocationInfo) *ResourceAllocationFlag { | ||
| return &ResourceAllocationFlag{cpu, mem} | ||
| } | ||
|
|
anfernee
reviewed
Nov 10, 2017
| if r.Reservation != nil { | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
do we care ExpandableReservation here?
There was a problem hiding this comment.
Good catch. It seems ExpandableReservation cannot be set to true for the VM fields. I'll see about just excluding the {cpu,mem}.expandable flags from the vm.change command.
There was a problem hiding this comment.
Yes please exclude, bc it´s a resource pool flag.
anfernee
approved these changes
Nov 10, 2017
Refactored resource pool related flags and simulator so we can use the same logic for VirtualMachine resource allocation.
dougm
force-pushed
the
vm-change-allocation
branch
from
2605fac
to
a894020
Compare
|
@dougm thx a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored resource pool related flags and simulator so we can use the same logic
for VirtualMachine resource allocation.