Add option to filter events by type #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtering specific event types reduces the chance of missing events, while keeping the event history collector page size on the low side.
cgtexmex
approved these changes
Dec 21, 2017
hickeng
reviewed
Dec 21, 2017
| assert_success | ||
|
|
||
| run govc events -type VmPoweredOffEvent -type VmPoweredOnEvent "vm/$vm" | ||
| [ ${#lines[@]} -eq 2 ] |
There was a problem hiding this comment.
You could do with an additional VM operation (guest operation or reconfigure or something) so that you can assert that you do not get an event for it. Or use the power events but omit -type VmPoweredOffEvent.
There was a problem hiding this comment.
Several events such as VmCreatedEvent, VmMacAssignedEvent, etc, are being filtered out here.. but yes could make it more explicit within the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering specific event types reduces the chance of missing events,
while keeping the event history collector page size on the low side.