Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test_suite a dictionary of lists instead of lists and strings #322

Closed
rnjudge opened this issue Jun 15, 2019 · 0 comments · Fixed by #327
Closed

Make test_suite a dictionary of lists instead of lists and strings #322

rnjudge opened this issue Jun 15, 2019 · 0 comments · Fixed by #327
Assignees
@rnjudge
Labels
assigned This issue has been assigned to someone who is actively working on it CI/CD Continuous Integration and Continuous Delivery technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred
Milestone
Release 0.5.0

Comments

@rnjudge
Copy link
Contributor

rnjudge commented Jun 15, 2019

Description
The test_suite dictionary in 'ci/test_files_touched.py' currently contains values of mixed types (both strings and lists of strings). As a result, we have to check for the instance type when we are adding the tests to the alltests string (line 117). An simpler way to do this would be to have a dictionary of only lists and remove the instance type check.

To Do

  1. Change all single-string values in test_suite with single-element lists.
  2. Remove the check for 'if isinstance' in line 117 and simply extend all elements to alltests instead of append.

Background
We got the script to run and then realized there was a cleaner way to do it. This issue is mostly a reminder for me to clean this up on Monday.

Super Issues
Enter the issue numbers this issue is work towards resolving
@rnjudge rnjudge added the technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred label Jun 15, 2019
@rnjudge rnjudge added this to the Release 0.5.0 milestone Jun 15, 2019
@rnjudge rnjudge self-assigned this Jun 15, 2019
@rnjudge rnjudge added assigned This issue has been assigned to someone who is actively working on it CI/CD Continuous Integration and Continuous Delivery labels Jun 15, 2019
rnjudge added a commit to rnjudge/tern that referenced this issue Jun 17, 2019
@rnjudge
ci: Make test_suite a dictionary of lists
731d50a 
The test_suite dictionary in 'ci/test_files_touched' used to contain
values of mixed types (both strings and lists of strings). As a result,
we were checking for the instance type before adding the value to the
alltests string.

This commit makes the following change:
  1) Changes all values in tests_suite to lists of strings, even if the
     list is only one element.

Resolves tern-tools#322

Signed-off-by: Rose Judge <[email protected]>
rnjudge added a commit to rnjudge/tern that referenced this issue Jun 17, 2019
@rnjudge
ci: Make test_suite a dictionary of lists
0bb17b0 
The test_suite dictionary in 'ci/test_files_touched' used to contain
values of mixed types (both strings and lists of strings). As a result,
we were checking for the instance type before adding the value to the
alltests string.

This commit makes the following change:
  1) Changes all values in tests_suite to lists of strings, even if the
     list is only one element.
  2) Removes the isinstance check before extending the value to alltests

Resolves tern-tools#322

Signed-off-by: Rose Judge <[email protected]>
@rnjudge rnjudge mentioned this issue Jun 17, 2019
Merged
rnjudge added a commit to rnjudge/tern that referenced this issue Jun 17, 2019
@rnjudge
ci: Make test_suite a dictionary of lists
370249b 
The test_suite dictionary in 'ci/test_files_touched' used to contain
values of mixed types (both strings and lists of strings). As a result,
we were checking for the instance type before adding the value to the
alltests string.

This commit makes the following change:
  1) Changes all values in tests_suite to lists of strings, even if the
     list is only one element.
  2) Removes the isinstance check before extending the value to alltests

Resolves tern-tools#322

Signed-off-by: Rose Judge <[email protected]>
rnjudge added a commit to rnjudge/tern that referenced this issue Jun 17, 2019
@rnjudge
ci: Make test_suite a dictionary of lists
ed54c30 
The test_suite dictionary in 'ci/test_files_touched' used to contain
values of mixed types (both strings and lists of strings). As a result,
we were checking for the instance type before adding the value to the
alltests string.

This commit makes the following change:
  1) Changes all values in tests_suite to lists of strings, even if the
     list is only one element.
  2) Removes the isinstance check before extending the value to alltests

Resolves tern-tools#322

Signed-off-by: Rose Judge <[email protected]>
rnjudge added a commit to rnjudge/tern that referenced this issue Jun 17, 2019
@rnjudge
ci: Make test_suite a dictionary of lists
d1cc1c8 
The test_suite dictionary in 'ci/test_files_touched' used to contain
values of mixed types (both strings and lists of strings). As a result,
we were checking for the instance type before adding the value to the
alltests string.

This commit makes the following change:
  1) Changes all values in tests_suite to lists of strings, even if the
     list is only one element.
  2) Removes the isinstance check before extending the value to alltests

Resolves tern-tools#322

Signed-off-by: Rose Judge <[email protected]>
nishakm pushed a commit that referenced this issue Jun 17, 2019
@rnjudge
ci: Make test_suite a dictionary of lists
4dbae0c 
The test_suite dictionary in 'ci/test_files_touched' used to contain
values of mixed types (both strings and lists of strings). As a result,
we were checking for the instance type before adding the value to the
alltests string.

This commit makes the following change:
  1) Changes all values in tests_suite to lists of strings, even if the
     list is only one element.
  2) Removes the isinstance check before extending the value to alltests

Resolves #322

Signed-off-by: Rose Judge <[email protected]>
rnjudge added a commit that referenced this issue Aug 28, 2019
@rnjudge
ci: Make test_suite a dictionary of lists
a8e4a6e 
The test_suite dictionary in 'ci/test_files_touched' used to contain
values of mixed types (both strings and lists of strings). As a result,
we were checking for the instance type before adding the value to the
alltests string.

This commit makes the following change:
  1) Changes all values in tests_suite to lists of strings, even if the
     list is only one element.
  2) Removes the isinstance check before extending the value to alltests

Resolves #322

Signed-off-by: Rose Judge <[email protected]>
rnjudge added a commit to rnjudge/tern that referenced this issue Jun 5, 2020
@rnjudge
ci: Make test_suite a dictionary of lists
2259ae7 
The test_suite dictionary in 'ci/test_files_touched' used to contain
values of mixed types (both strings and lists of strings). As a result,
we were checking for the instance type before adding the value to the
alltests string.

This commit makes the following change:
  1) Changes all values in tests_suite to lists of strings, even if the
     list is only one element.
  2) Removes the isinstance check before extending the value to alltests

Resolves tern-tools#322

Signed-off-by: Rose Judge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnjudge rnjudge

Labels
assigned This issue has been assigned to someone who is actively working on it CI/CD Continuous Integration and Continuous Delivery technical-debt Technical Debt - we should have addressed this right away but for "reasons" we deferred
Projects
None yet
Milestone
Release 0.5.0
Development

Successfully merging a pull request may close this issue.

ci: Make test_suite a dictionary of lists rnjudge/tern
1 participant
@rnjudge