Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #35

Open
vnmabus opened this issue Jan 23, 2024 · 0 comments
Open

Improve tests #35

vnmabus opened this issue Jan 23, 2024 · 0 comments

Comments

@vnmabus
Copy link
Owner

vnmabus commented Jan 23, 2024

There are a couple of ideas for improving the tests in this package.

For the tests, I think that the ideal thing would be to have each dataset as both binary and ASCII. Then it should be possible, maybe using a Pytest fixture, to pass the same tests for both versions, ensuring that all functionality work for both implementations.

Originally posted by @vnmabus in #34 (comment)

I think it could also be useful to include in the repo an R script that generates all those test data files.

Originally posted by @trossi in #34 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant