Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add datadog metrics [CORE-3091] #53

Merged
merged 9 commits into from
May 1, 2020
Merged

feat: add datadog metrics [CORE-3091] #53

merged 9 commits into from
May 1, 2020

Conversation

leartgjoni-voiceflow
Copy link
Contributor

@leartgjoni-voiceflow leartgjoni-voiceflow commented Apr 29, 2020 •
edited
Loading

Add vf-server datadog metrics system to alexa.

  • Easily improvable. invocation can be actually limited to invocations and a new interaction data point can be added to datadog.
  • related google PR

@leartgjoni-voiceflow leartgjoni-voiceflow added the in progress In progress, should not be merged label Apr 29, 2020
@effervescentia
Copy link
Contributor

effervescentia commented Apr 29, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@aa3d17e). Click here to learn what that means.
The diff coverage is n/a.

@leartgjoni-voiceflow leartgjoni-voiceflow changed the title feat: add datadog metrics feat: add datadog metrics [CORE-3091] Apr 29, 2020
@leartgjoni-voiceflow leartgjoni-voiceflow added ready for review and removed in progress In progress, should not be merged labels Apr 29, 2020
@leartgjoni-voiceflow leartgjoni-voiceflow merged commit 60d1074 into master May 1, 2020
@leartgjoni-voiceflow leartgjoni-voiceflow deleted the leart/datadog/CORE-3091 branch May 1, 2020 14:42
@voiceflow-dev
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

DecathectZero pushed a commit that referenced this pull request Sep 8, 2020
@leartgjoni-voiceflow @DecathectZero
feat: add datadog metrics [CORE-3091] (#53)
239d13f 
* feat: add datadog metrics

* chore: type

* test: fix old

* test: add new

* refactor: metrics class

* test: improved

* chore: reorder package.json

* chore: prettier

* refactor: no hashing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecathectZero DecathectZero DecathectZero approved these changes

Assignees
No one assigned
Labels
ready to merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leartgjoni-voiceflow @effervescentia @voiceflow-dev @DecathectZero