feat: events and directive #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecathectZero
added
the
in review
z4o4z
requested changes
Jun 1, 2020
| import { Command, Context, extractFrameCommand } from '@voiceflow/client'; | ||
|
|
||
| import { EventRequest, RequestType } from '@/lib/services/voiceflow/types'; | ||
| // import { mapSlots } from '@/lib/services/voiceflow/utils'; |
Comment on lines
7
to
9
| // export enum Request { | ||
| // INTENT = 'IntentRequest', | ||
| // } |
| const utilsObj = { | ||
| buildContext, | ||
| getEvent, | ||
| // handleEvent, |
Comment on lines
18
to
31
| // export const EventHandlerGenerator = (utils: typeof utilsObj): RequestHandler => ({ | ||
| // async canHandle(input: HandlerInput): Promise<boolean> { | ||
| // const context = await utils.buildContext(input); | ||
| // return !!getEvent(context); | ||
| // }, | ||
| // async handle(input: HandlerInput) { | ||
| // const context = await utils.buildContext(input); | ||
| // // based on the event, modify the context | ||
| // await handleEvent(context); | ||
| // input.attributesManager.setPersistentAttributes(context.getRawState()); | ||
|
|
||
| // return IntentHandler.handle(input); | ||
| // }, | ||
| // }); |
z4o4z
added
changes requested
and removed
in review
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 97.65% 95.65% -2.00%
==========================================
Files 88 92 +4
Lines 1578 1658 +80
Branches 260 273 +13
==========================================
+ Hits 1541 1586 +45
- Misses 27 62 +35
Partials 10 10
Continue to review full report at Codecov.
|
leartgjoni-voiceflow
suggested changes
Jun 1, 2020
| @@ -0,0 +1,50 @@ | |||
| import { HandlerFactory } from '@voiceflow/client'; | |||
| import { Directive } from 'ask-sdk-model'; | |||
| import _isString from 'lodash/isString'; | |||
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
DecathectZero
added a commit
that referenced
this pull request
Sep 8, 2020
* wip: add directive handlers * chore: handlers * chore: event setup * wip: event implementation * chore: fixed tests * test: add directive handler tests * chore: update client to make tests pass * chore: remove comments and clean up * chore: variable mapping Co-authored-by: leartgjoni-voiceflow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contingent on:
voiceflow/database: https://github.com/voiceflow/database/pull/41voiceflow/app: https://github.com/voiceflow/creator-app/pull/1612voiceflow/api: https://github.com/voiceflow/creator-api/pull/359renamed previous
eventHandlertopermissionHandlerthe new
eventHandleris for the event block, and attempts to intercept and modify the stack (like the intent block) but at the Alexa Handler level, not the Voiceflow Client Handler level.