Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty display on test tool #56

Merged
merged 3 commits into from
May 12, 2020
Merged

Conversation

leartgjoni-voiceflow
Copy link
Contributor

@leartgjoni-voiceflow leartgjoni-voiceflow commented May 12, 2020

todo: update client version with this

@leartgjoni-voiceflow leartgjoni-voiceflow added the in progress In progress, should not be merged label May 12, 2020
@linear
Copy link

linear bot commented May 12, 2020

CORE-1997 Test tool exits early when passing over an empty display block and display block in new project template

Steps to Reproduce

  • Create a new project
  • Add a display step to the canvas, do not configure it
  • Add a speak step, add something for it to say
  • Link them to the start block (start → display → speak)
  • Start the prototype, notice that it ends immediately when it hits the display step

Expected Behaviour

  • Should continue to the speak step

Context for Priority

This bug will be extremely visible to new users given that it is replicated in our new projecet template.

@effervescentia
Copy link
Contributor

Codecov Report

❗ No coverage uploaded for pull request base (master@da4b4b3). Click here to learn what that means.
The diff coverage is n/a.

@leartgjoni-voiceflow leartgjoni-voiceflow added ready for review and removed in progress In progress, should not be merged labels May 12, 2020
@leartgjoni-voiceflow leartgjoni-voiceflow merged commit 1931de7 into master May 12, 2020
@DecathectZero DecathectZero deleted the leart/CORE-1997 branch May 12, 2020 20:54
@voiceflow-dev
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

DecathectZero pushed a commit that referenced this pull request Sep 8, 2020
* fix: empty display on test tool

* refactor: use next handler

* chore: update client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants