feat: handling a randomized reprompt #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## leart/CORE-978 #59 +/- ##
===============================================
Coverage 97.68% 97.69%
===============================================
Files 89 89
Lines 1601 1602 +1
Branches 264 264
===============================================
+ Hits 1564 1565 +1
Misses 27 27
Partials 10 10
Continue to review full report at Codecov.
|
leartgjoni-voiceflow
suggested changes
May 28, 2020
| @@ -24,6 +24,7 @@ describe('noMatch handler unit tests', () => { | |||
| const block = { | |||
| blockID: 'block-id', | |||
| noMatches: ['the counter is {counter}'], | |||
| randomize: false, | |||
There was a problem hiding this comment.
we're testing with a boolean already in the next unit test, let's remove randomize altogether here to test undefined
refactor: removed randomize from one unit test to test undefined case instead
leartgjoni-voiceflow
pushed a commit
that referenced
this pull request
May 28, 2020
* feat: handling a randomized reprompt * feat: unit tests for no match randomize * feat: added randomize property to test object * Update noMatch.unit.ts refactor: removed randomize from one unit test to test undefined case instead
leartgjoni-voiceflow
added a commit
that referenced
this pull request
Jun 1, 2020
* wip: handle no matches * chore: comments * refactor: new handler * wip: add full speak capabitilies * chore: comments * test: fix old * test: new unit * chore: rename test * feat: handling a randomized reprompt (#59) * feat: handling a randomized reprompt * feat: unit tests for no match randomize * feat: added randomize property to test object * Update noMatch.unit.ts refactor: removed randomize from one unit test to test undefined case instead
DecathectZero
pushed a commit
that referenced
this pull request
Sep 8, 2020
* wip: handle no matches * chore: comments * refactor: new handler * wip: add full speak capabitilies * chore: comments * test: fix old * test: new unit * chore: rename test * feat: handling a randomized reprompt (#59) * feat: handling a randomized reprompt * feat: unit tests for no match randomize * feat: added randomize property to test object * Update noMatch.unit.ts refactor: removed randomize from one unit test to test undefined case instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds randomization for the reprompts.