-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nb_conda_kernels #651
Comments
Hi @jeiche this is really interesting. In fact, the main issue is that For more context, the issue with that extension is that it completely overrides the kernel manager. The new Jupyter Server includes a pluggable kernel discovery mechanism and I think that using it to make it work with conda environment is a really good fit. cc @kevin-bates. |
I've also seen this problem from Voila users, and because nb_conda_kernels needs updating really, I've recommended that users 'feeze' their kernels by removing nb_conda_kernels and just registering existing kernels manually. Of course this means that new kernels won't be discovered in Jupyter. There is a bit more info here for anyone trying this 'workaround': |
@SylvainCorlay - Just to clarify and manage expectations, Kernel Providers have not been merged into jupyter_server and likely won't be merged until 3.0 and the JEP has been ratified, etc. That said, I agree Conda kernels make for a perfect example of a kernel provider and work had even been started on an early prototype (just too early, unfortunately). Taking a brief look at the code, it seems like Voila is going to have to make changes to adopt Kernel Providers if/when they're available since they'll replace things like |
Version 2.3.0 of @kevin-bates is correct that proper support is going to have to wait for true kernel provider support to be incorporated into Jupyter itself. |
I personally am partial to my monkeypatching approach |
Yes, that was just me looking a bit too far forward :) thanks for chiming in.
Thanks for working on this. I really hope that the kernel provider mechanism will allow us to not have to monkey-patch! In the mean time, the solution on our side should be to document the behavior and point to the section in the documentation. |
Although Kernel Providers may have their own set of pain points, discovery and launch functionality is isolated and contained within each provider and each can co-exist with other providers. One area that provider authors should be aware of though, is the use of |
A tutorial to demonstrate how to set up |
If you're using nb_conda_kernels, voila fails to execute the notebook since it fails to find the kernelspec due to the fact that it implicitly assumes you're using Jupyter's KernelSpecManager. I propose making the following code snippet change in voila/app.py to address the issue.
Old:
New:
The text was updated successfully, but these errors were encountered: