Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to End testing #915

Closed
jtpio opened this issue Jun 24, 2021 · 0 comments · Fixed by #916
Closed

End to End testing #915

jtpio opened this issue Jun 24, 2021 · 0 comments · Fixed by #916
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Jun 24, 2021

Problem

Visual regressions can sometimes be introduced when making changes to Voila.

For example #846 is going to drastically change the way the frontend works, and it would be great to check if this big change is going to affect some of the Voila logic, rendering or features.

Proposed Solution

We should add Visual Regression tests, which has already been explored in #574 and #821.

One option would be to follow what JupyterLab, ipywidgets and bqplot (and potentially other repos) have done and adop Galata: https://github.com/jupyterlab/galata

If testing the Voila rendered page directly is not feasible with Galata, we might able to use the JupyterLab preview extension instead.

Additional context

@jtpio jtpio added the enhancement New feature or request label Jun 24, 2021
@jtpio jtpio mentioned this issue Jun 25, 2021
5 tasks
@jtpio jtpio closed this as completed in #916 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant