refactor: more accurate interface design and terminology #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to reduce the abstraction of core parts as much as possible, and use more precise terminology.
language-core
uses the term "Script" instead of "File", because "File" implies dependence on the File System and "Script" semantics are looser.language-core
SourceFile
interface toSourceScript
LanguageContext
interface andFileRegistry
interface are merged intoLanguage
interfaceFileRegistry.getVirtualCode
API, now you should use:language-service
ServicePlugin
interface toLanguageServicePlugin
Result
interface toProviderResult
LanguagePlugin.typescript
'sgetScript
hook togetServiceScript
LanguagePlugin.typescript
'sgetExtraScripts
hook togetExtraServiceScripts
ServiceContext.documents.getVirtualCodeByUri
, now you should use:ServiceContext.documents.getVirtualCodeUri
, now you should use: