Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify: fetch artist names with correct localization #355

Open
phts opened this issue Sep 4, 2024 · 1 comment · May be fixed by #356
Open

Spotify: fetch artist names with correct localization #355

phts opened this issue Sep 4, 2024 · 1 comment · May be fixed by #356

Comments

@phts
Copy link
Contributor

phts commented Sep 4, 2024

Spotify API allows Accept-Language request header to receive correct Artist names, written in native language, instead of transliteration.

However spotify-web-api-node does not allow setting any request headers.

My pull request thelinmichael/spotify-web-api-node#507 seems never to be merged , due to inactivity of the author.

In my forked plugin, I am using my fork of spotify-web-api-node and it works as expected.

Before: After:
Screen Shot 2024-09-02 at 23 15 04 Screen Shot 2024-09-02 at 23 07 35

I don't create any PRs here, because I suggest creating your own fork of spotify-web-api-node to have full control of it, and apply similar changes there. Plugin changes look like that: phts@5ccc58a

@volumio
Copy link
Owner

volumio commented Sep 10, 2024

Very nice find @phts !

Forked the lib as you suggested:
https://github.com/volumio/spotify-web-api-node

Looking forward for the PR to include this on the lib (and please update the package.json of plugin as well)

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants