Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voxel-keys requires either kb-bindings or game-shell #2

Open
pietrovismara opened this issue Nov 22, 2016 · 1 comment
Open

voxel-keys requires either kb-bindings or game-shell #2

pietrovismara opened this issue Nov 22, 2016 · 1 comment

Comments

@pietrovismara
Copy link

I'm trying to load voxel-keys but i get this error. So i tried to install game-shell with npm and loaded it via voxel-plugins:

    var plugins = createPlugins(game, {require:require});
    plugins.add('game-shell', {});
    plugins.add('voxel-keys', {});
    plugins.loadAll();

But again same error. I tried to switch to kb-bindings with no result.
Then, i found this message on kb-bindings README.md:

kb-bindings is now deprecated in favor of the following modules:

kb-controls 0.2.0+ (includes configurable bindings map)
voxel-keys (includes key events)

Now i'm really confused.
I also examined the code of voxel-keys and of kb-bindings, and i don't understand how they could cooperate.

Could you help me?

@rajch
Copy link

rajch commented Nov 29, 2016

voxel-keys tries to use the game.buttons.binding property, which is supposed to come from kb-control. voxel-engine currently uses kb-controls 0.0.2, which provides game.buttons, but not game.buttons.binding. Ideally, voxel-engine should use kb-controls 0.2.0+. I forced this in my project using shrinkwrap. I'll probably submit a pull request to voxel-engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants