Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module supports http://, https:// or file:// as baseurl only without checking other yum plugins that support other schemes #151

Open
Voovode opened this issue Dec 2, 2019 · 1 comment

Comments

@Voovode
Copy link

Voovode commented Dec 2, 2019

Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.10.12
  • Ruby: 2.4.9p362
  • Distribution: CentOS 7
  • Module version: 4.0.0

How to reproduce (e.g Puppet code you use)

Hiera values below:

yum::managed_repos:
    - 'my-project'
yum::repos:
    my-project:
        ensure: 'present'
        enabled: true
        descr: 'My Project Repo'
        baseurl: "gs://my-project-%{::envname}-repo/myproject"
        gpgcheck: false
        gpgkey: '--'
        target: '/etc/yum.repos.d/my-project.repo'

eg. try to use a different baseurl, other than http/https/file, like me above.

What are you seeing

I'm using the yum-gs-iam plugin for yum, which allows yum to be able to fetch packages from GCS.

puppet-yum plugin will try to validate baseurl without letting yum do so.

What behaviour did you expect instead

Since I've got a yum plugin installed to handle the gs:// baseurl, module should not check it?

Output log

Dec 02 12:14:33 test-server puppet[1848]: Error: Parameter baseurl failed on Yumrepo[spareroom-secure]: Validate method failed for class baseurl: Must be a valid URL at /etc/puppetlabs/code/modules/yum/manifests/init.pp:136

Any additional information you'd like to impart

@Voovode Voovode changed the title Module expects http://, https:// or file:// as baseurl without checking other yum plugins that do so Module supports http://, https:// or file:// as baseurl only without checking other yum plugins that support other schemes Dec 2, 2019
@TJM
Copy link

TJM commented Dec 2, 2019

This module should probably try not to validate the URL at all.

(EDIT: I mis-read this... but still stand behind the module should not be trying to validate the URL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants