Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in Class view #816

Closed
vchepkov opened this issue Apr 8, 2023 · 3 comments · Fixed by #868
Closed

Broken links in Class view #816

vchepkov opened this issue Apr 8, 2023 · 3 comments · Fixed by #868
Labels

Comments

@vchepkov
Copy link
Contributor

vchepkov commented Apr 8, 2023

In puppetboard 4.3.0 when ENABLE_CLASS = True, in class view when you click on the class name you get 'Not Found' message. I presume it should lead to https://raw.githubusercontent.com/voxpupuli/puppetboard/master/screenshots/class.png instead

@vchepkov vchepkov added the bug label Apr 8, 2023
@vchepkov
Copy link
Contributor Author

vchepkov commented Apr 8, 2023

cc: @lcharreau

@lcharreau
Copy link

Hello @vchepkov

I'm sorry but I can't reproduce this case.

Here is my most minimal docker-compose configuration with a single worker, without a scheduler to pre-compute the results (default SCHEDULER_ENABLED=False) and using the cache memory (default CACHE_TYPE=SimpleCache):

services:
  puppetboard:
    container_name: puppetboard
    hostname: puppetboard
    image: ghcr.io/voxpupuli/puppetboard:4.3.0
    restart: unless-stopped
    ports:
    - 127.0.0.1:8082:80
    volumes:
    - "/etc/puppetlabs/puppetdb/ssl:/etc/puppetlabs/puppetdb/ssl:ro"
    extra_hosts:
    - <puppetdb_hostname>:10.54.97.12
    environment:
    - PUPPETBOARD_WORKERS=1
    - PUPPETDB_HOST=<puppetdb_hostname>
    - PUPPETDB_PORT=8081
    - PUPPETDB_PROTO=https
    - PUPPETDB_SSL_VERIFY=/etc/puppetlabs/puppetdb/ssl/ca.pem
    - PUPPETDB_KEY=/etc/puppetlabs/puppetdb/ssl/private.pem
    - PUPPETDB_CERT=/etc/puppetlabs/puppetdb/ssl/public.pem
    - ENABLE_CLASS=True
    # - SCHEDULER_ENABLED=True
    # - CACHE_TYPE=MemcachedCache
    - UNRESPONSIVE_HOURS=16
    networks:
      app_net:
        ipv4_address: 10.10.30.10
  # memcached:
  #   container_name: memcached
  #   hostname: memcached
  #   image: memcached:latest
  #   restart: always
  #   networks:
  #     app_net:
  #       ipv4_address: 10.10.30.11

networks:
  app_net:
    driver: bridge
    ipam:
      driver: default
      config:
      - subnet: 10.10.30.0/24

If I understand well, you see the list of Puppet classes with the columns "Nb nodes", "Failure", ...
and when you click on a class to display the concerned nodes, you have a 404 error "Not Found" ?

What do you have in the href link of the class?

<a href="/class_resource/${class_name}">${class_name}</a>

@vchepkov
Copy link
Contributor Author

The url has '/all/' in it, if I manually remove it to conform to your pattern, the page does open
I have 'all' environments as default, I think if you select 'All environments' in the drop-down menu, you should be able to reproduce it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants