Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label PRs with merge conflicts #1

Closed
bastelfreak opened this issue Jun 9, 2019 · 1 comment
Closed

Label PRs with merge conflicts #1

bastelfreak opened this issue Jun 9, 2019 · 1 comment
Labels
discussion Further information is requested enhancement New feature or request

Comments

@bastelfreak
Copy link
Member

bastelfreak commented Jun 9, 2019

Proper management for our issues and pull requests is important. Automation can help us a lot. Our conecpt: There are pull requests where we need to act (review, merge) and where we wait for the contributor. github provides the mergeable attribute in the API. It allows us to check if there is a merge conflict or not. If there is a conflict, we need to add the label. If it gets rebased, we need to remove the label

curl -s https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/150 | jq .'mergeable' 
false

If desired, we could configure the application within the repositories, so github will deliver events to us (so we don't need to poll for this, which would be stupid).


The GitHub API allows us to update labels,


GitHub does not send out emails to collaborators if their pull request isn't mergeable nor when a label gets added. So in addition to the labels we should probably add an automatic comment to the PR?

@bastelfreak bastelfreak added the enhancement New feature or request label Jun 9, 2019
@bastelfreak bastelfreak added the discussion Further information is requested label Jun 10, 2019
@Flipez
Copy link
Member

Flipez commented Jul 30, 2019

Implemented with #35

@Flipez Flipez closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Further information is requested enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants