fix(voicenotify): use emoji microphone instead of discord emoji #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - add vscode settings to ignores - remove experimental json module usage
vpctorr
added a commit
that referenced
this pull request
Feb 20, 2022
vpctorr
added a commit
that referenced
this pull request
Feb 20, 2022
This was referenced Feb 20, 2022
Closed
Closed
Closed
Merged
vpctorr
added a commit
that referenced
this pull request
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a couple of pictures from before and after of the push notifications. Enclosing the Unicode mic emoji in backticks was as close as I could get because of the way discord auto-converts emojis to their corresponding
:...:syntax.I also switched out the experimental JSON module support for a plain old
readFileSyncand parse mostly because I was having issues running the server with it. It was telling me that I needed to add anassert { type: 'json' }to the import statement, but when doing that, eslint wasn't happy and wanted an additional plugin, vscode didn't recognize the syntax, and SonarLint couldn't parse the file. Rather than making significant adjustments to the package config, I figured it would be the lesser evil to go back to a more primitive way of obtaining the package.json info.