feat: convert VoiceNotify to discord.js v13 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will keep the workspace package versions up to date in the package-lock.json file
- Discord.js is no longer installed as a root workspace dep. - It is instead installed individually in each package. - This allows the VoiceNotify package to move foward to v13 without affecting the other packages.
Harvtronix
force-pushed
the
discord-js-update
branch
from
4d7a17c
to
a36ef17
Compare
- also undo a commit that had been force pushed
|
Thanks for the great work! |
Merged
vpctorr
pushed a commit
that referenced
this pull request
Jan 24, 2023
vpctorr
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is definitely not thoroughly tested, but the happy path at least works. I was able to do the following successfully:
enablecommand to add a notification with threshold1to a channel (didn't do anything with role notifications)disablecommand to remove the notification from the channeldebugcommand to display debug informationFeel free to tweak or modify in any way you want.