From 9cc9ec5cda2db0bf54f5de8008bb23d33849656a Mon Sep 17 00:00:00 2001
From: Wilfred van der Deijl <wilfred@vanderdeijl.com>
Date: Fri, 13 Oct 2017 15:44:13 +0200
Subject: [PATCH] only detect xsi:nil if its value is `true`

---
 lib/wsdl.js                                   |  4 +-
 .../Dummy__should_handle_nil_false/common.xsd | 28 +++++++++++++
 .../Dummy__should_handle_nil_false/name.xsd   | 19 +++++++++
 .../request.json                              |  6 +++
 .../request.xml                               |  1 +
 .../response.json                             | 12 ++++++
 .../response.xml                              | 14 +++++++
 .../Dummy__should_handle_nil_false/soap.wsdl  | 42 +++++++++++++++++++
 8 files changed, 125 insertions(+), 1 deletion(-)
 create mode 100644 test/request-response-samples/Dummy__should_handle_nil_false/common.xsd
 create mode 100644 test/request-response-samples/Dummy__should_handle_nil_false/name.xsd
 create mode 100644 test/request-response-samples/Dummy__should_handle_nil_false/request.json
 create mode 100644 test/request-response-samples/Dummy__should_handle_nil_false/request.xml
 create mode 100644 test/request-response-samples/Dummy__should_handle_nil_false/response.json
 create mode 100644 test/request-response-samples/Dummy__should_handle_nil_false/response.xml
 create mode 100644 test/request-response-samples/Dummy__should_handle_nil_false/soap.wsdl

diff --git a/lib/wsdl.js b/lib/wsdl.js
index e3d170bcc..5db76f8cb 100644
--- a/lib/wsdl.js
+++ b/lib/wsdl.js
@@ -1325,7 +1325,9 @@ WSDL.prototype.xmlToObject = function(xml, callback) {
 
     for(attributeName in elementAttributes){
       var res = splitQName(attributeName);
-      if (res.name === 'nil' && xmlns[res.prefix] === 'http://www.w3.org/2001/XMLSchema-instance') {
+      if (res.name === 'nil' && xmlns[res.prefix] === 'http://www.w3.org/2001/XMLSchema-instance' && elementAttributes[attributeName] &&
+          (elementAttributes[attributeName].toLowerCase() === 'true' || elementAttributes[attributeName] === '1')
+        ) {
         hasNilAttribute = true;
         break;
       }
diff --git a/test/request-response-samples/Dummy__should_handle_nil_false/common.xsd b/test/request-response-samples/Dummy__should_handle_nil_false/common.xsd
new file mode 100644
index 000000000..e04c0710b
--- /dev/null
+++ b/test/request-response-samples/Dummy__should_handle_nil_false/common.xsd
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<xs:schema xmlns:tns="http://www.Dummy.com/Common/Types" xmlns:xs="http://www.w3.org/2001/XMLSchema" targetNamespace="http://www.Dummy.com/Common/Types" elementFormDefault="qualified" attributeFormDefault="unqualified">
+	<xs:complexType name="DummyResult">
+		<xs:sequence>
+			<xs:element name="DummyList" type="tns:DummyList" minOccurs="0"/>
+		</xs:sequence>
+		<xs:attribute name="code" type="xs:string" use="optional"/>
+	</xs:complexType>
+	<xs:complexType name="Dummy">
+		<xs:simpleContent>
+			<xs:extension base="xs:string">
+				<xs:attribute name="language" type="xs:language" use="optional"/>
+			</xs:extension>
+		</xs:simpleContent>
+	</xs:complexType>
+	<xs:complexType name="DummyList">
+		<xs:sequence>
+			<xs:element name="DummyElement" type="tns:Dummy" maxOccurs="unbounded"/>
+		</xs:sequence>
+	</xs:complexType>
+    <xs:complexType name="DummyFilter">
+        <xs:sequence>
+            <xs:element name="DummyIntFilter" type="xs:string" minOccurs="0"/>
+            <xs:element name="DummyStringFilter" type="xs:string" minOccurs="0"/>
+        </xs:sequence>
+    </xs:complexType>
+</xs:schema>
+
diff --git a/test/request-response-samples/Dummy__should_handle_nil_false/name.xsd b/test/request-response-samples/Dummy__should_handle_nil_false/name.xsd
new file mode 100644
index 000000000..a515b88c3
--- /dev/null
+++ b/test/request-response-samples/Dummy__should_handle_nil_false/name.xsd
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<xs:schema xmlns:c="http://www.Dummy.com/Common/Types" xmlns:xs="http://www.w3.org/2001/XMLSchema" targetNamespace="http://www.Dummy.com/Name/Types" elementFormDefault="qualified" attributeFormDefault="unqualified">
+	<xs:import namespace="common.xsd" schemaLocation="common.xsd"/>
+	<xs:element name="DummyRequest">
+		<xs:complexType>
+			<xs:sequence>
+				<xs:element name="DummyField1" type="xs:string" minOccurs="0"/>
+				<xs:element name="DummyFilter" type="c:DummyFilter" minOccurs="0"/>
+			</xs:sequence>
+		</xs:complexType>
+	</xs:element>
+	<xs:element name="DummyResponse">
+		<xs:complexType>
+			<xs:sequence>
+				<xs:element name="DummyResult" type="c:DummyResult"/>
+			</xs:sequence>
+		</xs:complexType>
+	</xs:element>
+</xs:schema>
diff --git a/test/request-response-samples/Dummy__should_handle_nil_false/request.json b/test/request-response-samples/Dummy__should_handle_nil_false/request.json
new file mode 100644
index 000000000..52d6f57f7
--- /dev/null
+++ b/test/request-response-samples/Dummy__should_handle_nil_false/request.json
@@ -0,0 +1,6 @@
+{
+  "DummyField1": "Humpty",
+  "DummyFilter": {
+    "DummyStringFilter": "Dumpty"
+  }
+}
diff --git a/test/request-response-samples/Dummy__should_handle_nil_false/request.xml b/test/request-response-samples/Dummy__should_handle_nil_false/request.xml
new file mode 100644
index 000000000..b4ceed77f
--- /dev/null
+++ b/test/request-response-samples/Dummy__should_handle_nil_false/request.xml
@@ -0,0 +1 @@
+<?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"  xmlns:tns="http://www.Dummy.com" xmlns:n="http://www.Dummy.com/Name/Types"><soap:Body><n:DummyRequest xmlns:n="http://www.Dummy.com/Name/Types" xmlns="http://www.Dummy.com/Name/Types"><n:DummyField1>Humpty</n:DummyField1><n:DummyFilter><c:DummyStringFilter xmlns:c="http://www.Dummy.com/Common/Types">Dumpty</c:DummyStringFilter></n:DummyFilter></n:DummyRequest></soap:Body></soap:Envelope>
\ No newline at end of file
diff --git a/test/request-response-samples/Dummy__should_handle_nil_false/response.json b/test/request-response-samples/Dummy__should_handle_nil_false/response.json
new file mode 100644
index 000000000..f680181d2
--- /dev/null
+++ b/test/request-response-samples/Dummy__should_handle_nil_false/response.json
@@ -0,0 +1,12 @@
+{
+  "DummyResult": {
+    "DummyList": {
+      "DummyElement": {
+        "attributes": {
+          "xsi:nil": "false"
+        },
+        "$value":"Dummy Element Entry"
+      }
+    }
+  }
+}
diff --git a/test/request-response-samples/Dummy__should_handle_nil_false/response.xml b/test/request-response-samples/Dummy__should_handle_nil_false/response.xml
new file mode 100644
index 000000000..d60ee3c43
--- /dev/null
+++ b/test/request-response-samples/Dummy__should_handle_nil_false/response.xml
@@ -0,0 +1,14 @@
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:tns="http://www.Dummy.com" xmlns:n="http://www.Dummy.com/Name/Types" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+    <soap:Header></soap:Header>
+    <soap:Body>
+       <n:DummyResponse>
+           <n:DummyResult>
+               <c:DummyList xmlns:c="http://www.Dummy.com/Common/Types">
+                   <c:DummyElement xsi:nil="false">
+                       Dummy Element Entry
+                   </c:DummyElement>
+               </c:DummyList>
+           </n:DummyResult>
+       </n:DummyResponse>
+    </soap:Body>
+</soap:Envelope>
diff --git a/test/request-response-samples/Dummy__should_handle_nil_false/soap.wsdl b/test/request-response-samples/Dummy__should_handle_nil_false/soap.wsdl
new file mode 100644
index 000000000..814ba1bf5
--- /dev/null
+++ b/test/request-response-samples/Dummy__should_handle_nil_false/soap.wsdl
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<wsdl:definitions xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" 
+xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" 
+xmlns:xs="http://www.w3.org/2001/XMLSchema" 
+xmlns:tns="http://www.Dummy.com"  xmlns:n="http://www.Dummy.com/Name/Types"  xmlns:ns="http://schemas.xmlsoap.org/soap/encoding/" targetNamespace="http://www.Dummy.com">
+	<wsdl:types>
+		<xs:schema>
+			<xs:import namespace="http://www.Dummy.com/Common/Types" schemaLocation="common.xsd"/>
+			<xs:import namespace="http://www.Dummy.com/Name/Types" schemaLocation="name.xsd"/>
+		</xs:schema>
+	</wsdl:types>
+	<wsdl:message name="DummyRequest">
+		<wsdl:part name="DummyRequest" element="n:DummyRequest"/>
+	</wsdl:message>
+	<wsdl:message name="DummyResponse">
+		<wsdl:part name="DummyResponse" element="n:DummyResponse"/>
+	</wsdl:message>
+	<wsdl:portType name="DummyPortType">
+		<wsdl:operation name="Dummy">
+			<wsdl:input message="tns:DummyRequest"/>
+			<wsdl:output message="tns:DummyResponse"/>
+		</wsdl:operation>
+	</wsdl:portType>
+	<wsdl:binding name="DummyBinding" type="tns:DummyPortType">
+		<soap:binding style="document" transport="http://schemas.xmlsoap.org/soap/http"/>
+		<wsdl:operation name="Dummy">
+			<soap:operation soapAction="http://www.Dummy.com#Dummy" style="document"/>
+			<wsdl:input>
+				<soap:body use="literal"/>
+			</wsdl:input>
+			<wsdl:output>
+				<soap:body use="literal"/>
+			</wsdl:output>
+		</wsdl:operation>
+	</wsdl:binding>
+	<wsdl:service name="DummyService">
+		<wsdl:port name="DummyPortType" binding="tns:DummyBinding">
+			<soap:address location="http://www.Dummy.com/"/>
+		</wsdl:port>
+	</wsdl:service>
+</wsdl:definitions>
+