Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: File not found: job/src/job_class.coffee #1

Closed
chhib opened this issue Jun 12, 2014 · 10 comments
Closed

error: File not found: job/src/job_class.coffee #1

chhib opened this issue Jun 12, 2014 · 10 comments

Comments

@chhib
Copy link

chhib commented Jun 12, 2014

$ mrt add jobCollection
smart.json changed.. installing from smart.json
✓ jobCollection
    tag: https://github.com/vsivsi/meteor-job-collection.git#v0.0.2
Done installing smart packages
Stand back while Meteorite does its thing
Done installing smart packages
Ok, everything's ready. Here comes Meteor!

=> Errors while scanning packages:

While building package `jobCollection`:
error: File not found: job/src/job_class.coffee

Seems the package can't find the source in the NPM module. This was created from a new Meteor project from scratch.

@vsivsi
Copy link
Owner

vsivsi commented Jun 12, 2014

I couldn't repro this until I blew-away my .meteorite directory, and now I see it.

In v0.0.1 the meteor-job package was included as a git subproject, I removed that in v0.0.2 and replaced it with the reference to the npm package, and resolving that seems to be blowing up. Sorry I missed this, meteorite's package cache must have retained the subproject directory and masked this issue.

I'm on it...

@vsivsi
Copy link
Owner

vsivsi commented Jun 12, 2014

I just published v0.0.3 to Atmosphere. That should fix it... Please let me know how that works for you.

I reverted to including meteor-job as a subproject for now. I spaced and forgot that npm packages can't be expected to "just work" on the Meteor client, even if they are carefully written to have no dependencies on node. I'll need to dig a little further to sort that out...

In any case this should fix the issue you are seeing. And thanks for reporting it and being brave enough to try out jobCollection. I'm using it in my own work and I think it has the potential to solve a lot of problems for many Meteor projects, but it's early days. Feedback on any aspect of the package would be most welcomed.

@chhib
Copy link
Author

chhib commented Jun 12, 2014

The error remained despite mrt update. Also, I uninstalled and then reinstalled meteorite. Still an error. See from a completely new project:

~/Code $ meteor create jobCollection
jobCollection: created.

To run your new app:
   cd jobCollection
   meteor
~/Code $ cd jobCollection/
~/C/jobCollection $ mrt add jobCollection
✓ jobCollection
    tag: https://github.com/vsivsi/meteor-job-collection.git#v0.0.3

Done installing smart packages

Stand back while Meteorite does its thing

Done installing smart packages

Ok, everything's ready. Here comes Meteor!

=> Errors while scanning packages:

While building package `jobCollection`:
error: File not found: job/src/job_class.coffee

/usr/local/lib/node_modules/meteorite/lib/command.js:41
            throw "Command exited with " + code + "/" + signal;
                                                      ^
Command exited with 1/null
~/C/jobCollection $

Would it work if you created an atmosphere project of meteor-job, and than added that as a package dependancy in your smart.json?

I would really like to get this package running!

@vsivsi
Copy link
Owner

vsivsi commented Jun 12, 2014

Hmmm. I'm not able to reproduce this.

You say that you reinstalled Meteorite. Did you try deleting the .meteorite subdirectory from your home directory?

Here is what I did to attempt to repro, everything is fine on my end:

cd ~
rm -rf .meteorite
meteor create jobTest
cd jobTest
mrt add jobCollection
mrt

Try that... In the meantime, I'll try this on a completely clean machine and see what happens.

@vsivsi
Copy link
Owner

vsivsi commented Jun 12, 2014

OK, I just reproduced this on the clean machine. Very strange that my dev box is masking this problem again... I'll post a fix as soon as I figure out why it's working in one place but not the other.

@vsivsi
Copy link
Owner

vsivsi commented Jun 12, 2014

I just published v0.0.4. All I did was remove and re-add the git submodule for meteor-job in the project, but it seems to have fixed the issue on my clean machine. Something about how I reverted the submodule in v0.0.3 caused the ./job submodule directory not to be populated in some cases.

Let me know if this solves the issue. (Finally!)

@vsivsi
Copy link
Owner

vsivsi commented Jun 12, 2014

Scratch that, I just tried again with a brand new project on the clean machine and I'm seeing the error again... Argh. Okay, I'm going to step back and really get to the bottom of this.

Here's what works for me, but I don't know exactly why...

cd ~
rm -rf .meteorite
meteor create jobTest
cd jobTest
mrt add jobCollection   # This fails
mrt update
mrt   # This succeeds

What I don't understand is what is happening differently between the add and the update. The add doesn't seem to be fetching the git submodule, but the update does. This is particularly baffling because I have other Atmosphere packages that similarly use git submodules and I've never encountered any problems like this before.

Please let me know if the "add then update" workaround above works for you.

@vsivsi
Copy link
Owner

vsivsi commented Jun 12, 2014

I just published v0.0.5 and I now understand what was happening and why...

The git submodule weirdness was caused by my accidental use of a private github SSH URI in the .gitmodules file, instead of the corresponding public HTTPS github URI. Since only my dev box has the private key for that SSH URI, it failed everywhere but there.

I have tried this every way I can think of on my non-dev machine and it seems solid. Please give it another shot and let me know how it goes for you.

@chhib
Copy link
Author

chhib commented Jun 13, 2014

Great! A simple mrt update didn't help, but after purging the .meteorite folder, I got it working. Thanks a lot - looking forward to trying it out.

@vsivsi
Copy link
Owner

vsivsi commented Jun 13, 2014

I'm glad that finally did it. Let me know how it goes with jobCollection. I'm working on a sample app right now, which should be up before Monday. Enjoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants