Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Autoprefixer #85

Closed
Grafikart opened this issue Apr 14, 2016 · 12 comments
Closed

Feature : Autoprefixer #85

Grafikart opened this issue Apr 14, 2016 · 12 comments

Comments

@Grafikart
Copy link
Contributor

Grafikart commented Apr 14, 2016

Since this template is able to load CSS I was wondering if you would be interested into adding autoprefixer.

  • PostCSS loader will be used
  • browser support would be set using config.js file
  • it will be added using cssLoaders()

I can do a PR if you are interested.

@Grafikart Grafikart changed the title PR Idea : Autoprefixer Feature : Autoprefixer Apr 14, 2016
@yyx990803
Copy link
Contributor

yyx990803 commented Apr 14, 2016

vue-loader actually already does autoprefixing for component CSS: http://vuejs.github.io/vue-loader/features/postcss.html

But yeah it doesn't get applied to non-component CSS, so I like your proposal, we can turn off vue-loader's own stuff and centralize it inside cssLoaders() and config.js.

@Grafikart
Copy link
Contributor Author

Ok I'll work on it tomorrow. I'll close this issue when the PR is submitted

@shentao
Copy link

shentao commented May 10, 2016

@Grafikart how is it going? Just stumbled on this problem myself.

@Grafikart
Copy link
Contributor Author

I did this feature for a project but I didn't add this to the template. Is there a way to test a local template @yyx990803 ? I don't want to make a broken PR :)

@chrisvfritz
Copy link
Contributor

@Grafikart I recommend forking the template, then you can run vue init Grafikart/webpack name-of-test-project to generate a new project using your fork.

@chrisvfritz
Copy link
Contributor

@Grafikart Just pinging on this. Anything we can do to help?

@Grafikart
Copy link
Contributor Author

No it's fine I just did the missing commits

@guidobouman
Copy link
Contributor

You can actually import an external stylesheet in your top-most (App) component. That gets parsed as well, right? One implementation to rule them all.

@heygambo
Copy link

heygambo commented Jul 6, 2016

I've added a new entry for other sass files that I don't want to go into a vue component directly. Unfortunately another sass entry doesn't get the autoprefixing. Is that something that can be added easily? I'm trying to figure this out for hours now.

Adding sass directly to the webpack modules hash breaks everything unfortunately.

@guidobouman
Copy link
Contributor

That's what they're working on here.

For now you could import it in your topmost component. That way you don't need another entry.

@pksunkara
Copy link
Contributor

@Grafikart Do you need any help on this?

@guidobouman
Copy link
Contributor

Autoprefixer is in the latest template release. This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants