-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime-vapor): watchEffect
/watch
and onEffectCleanup
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
LittleSound
changed the title
feat: watchEffect and onEffectCleanup
feat: Dec 18, 2023
watchEffect
/watch
and onEffectCleanup
11 |
sxzz
approved these changes
Dec 23, 2023
sxzz
changed the title
feat:
feat(runtime-vapor): Dec 23, 2023
watchEffect
/watch
and onEffectCleanup
watchEffect
/watch
and onEffectCleanup
baiwusanyu-c
added a commit
that referenced
this pull request
Jan 3, 2024
� Conflicts: � packages/runtime-vapor/src/directive.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #67
onEffectCleanup
Additionally, provide support for
watch
About the scheduler for
watchEffect
/watch
Warning
Update: The function of
scheduler: rendering
in this PR will be replaced by Render Watch API.I added a scheduler functions for
doWatch
inscheduler.ts
: sync (vaporSyncScheduler
), pre (vaporPreScheduler
), post (vaporPostScheduler
). These three schedulers will be selected according to the flush option. In addition, there is a fourth scheduler: rendering (vaporRenderingScheduler
). WhenwatchEffect
/watch
is called in the render function, its default scheduler changes from pre to rendering.The flush order of these four schedulers is as follows:
The following is a picture I drew to describe the process: