Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): do not remove dep from depsMap when cleaning up deps of computed #11995

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

lehni
Copy link
Contributor

@lehni lehni commented Sep 21, 2024

This is a follow up of 960706e

I have not managed to isolate a simple test-case yet, but in our app, some input fields appear to loose reactivity after a while without this fix

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+10 B) 38 kB (+5 B) 34.2 kB (-28 B)
vue.global.prod.js 160 kB (+10 B) 58 kB (+6 B) 51.5 kB (-47 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49 kB (+10 B) 18.9 kB (+4 B) 17.2 kB (+16 B)
createApp 55.6 kB (+10 B) 21.4 kB (+7 B) 19.5 kB (-48 B)
createSSRApp 59.6 kB (+10 B) 23.1 kB (+7 B) 21 kB (+9 B)
defineCustomElement 60.4 kB (+10 B) 22.9 kB (+8 B) 20.9 kB (+62 B)
overall 69.3 kB (+10 B) 26.5 kB (+1 B) 24.1 kB (+10 B)

Copy link

pkg-pr-new bot commented Sep 21, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11995

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11995

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11995

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11995

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11995

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11995

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11995

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11995

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11995

vue

pnpm add https://pkg.pr.new/vue@11995

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11995

commit: 4592b57

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Sep 21, 2024
@yyx990803
Copy link
Member

Thanks for catching this - I was able to create a test case in 4592b57

@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 22, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@yyx990803 yyx990803 merged commit 0267a58 into vuejs:main Sep 22, 2024
13 checks passed
@lehni lehni deleted the fix/reactivity-cleanup-deps-from-computed branch September 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants