feat(compiler-sfc): export dependencies for plain css and css preproc… #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
less/less.js#3508. The less imports need next version publish.Them already fix it. |
yyx990803
reviewed
Jun 25, 2020
underfin
commented
Jun 26, 2020
| preprocessOptions: { | ||
| // test with file will get error which `import.scss is not find` | ||
| importer: function(url: string, prev: string, done: string) { | ||
| if (url === 'import.scss') { |
There was a problem hiding this comment.
I always got error which import.scss is not find. I try mock fs and path ,but that not work.
other, the test.scss will be parsed with 'http://localhost/test.scss'.
I don‘t reslove the error ... and need you take a look.
csr632
reviewed
Jul 16, 2020
Otherwise dart-sass thinks it is running in the browser due to jsdom
yyx990803
force-pushed
the
css-preprocessor-dep
branch
from
6751a86
to
4592bc2
Compare
|
I figured out the weird testing issues - Jest is running in jsdom env by default and that makes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…essor
@import