Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router navigation bug when wrapped with a transition #1408

Closed
wucdbm opened this issue Jun 19, 2020 · 4 comments
Closed

Router navigation bug when wrapped with a transition #1408

wucdbm opened this issue Jun 19, 2020 · 4 comments

Comments

@wucdbm
Copy link

wucdbm commented Jun 19, 2020

Version

3.0.0-beta.15

Reproduction link

https://codesandbox.io/s/sweet-galileo-iy3ug?file=/src/main.js

Steps to reproduce

"dependencies": {
"axios": "^0.19.2",
"bulma": "^0.9.0",
"core-js": "^3.6.5",
"lodash-es": "^4.17.15",
"register-service-worker": "^1.7.1",
"vue": "^3.0.0-beta.15",
"vue-class-component": "8.0.0-alpha.6",
"vue-property-decorator": "9.0.0",
"vue-router": "^4.0.0-alpha.13",
"vuex": "^4.0.0-beta.2",
"webpack-build-notifier": "^2.0.1"
},
"devDependencies": {
"@types/jest": "^26.0.0",
"@types/lodash-es": "^4.17.3",
"@typescript-eslint/eslint-plugin": "^3.3.0",
"@typescript-eslint/parser": "^3.3.0",
"@vue/cli-plugin-babel": "~4.4.4",
"@vue/cli-plugin-e2e-cypress": "~4.4.4",
"@vue/cli-plugin-eslint": "~4.4.4",
"@vue/cli-plugin-pwa": "~4.4.4",
"@vue/cli-plugin-router": "~4.4.4",
"@vue/cli-plugin-typescript": "~4.4.4",
"@vue/cli-plugin-unit-jest": "~4.4.4",
"@vue/cli-plugin-vuex": "~4.4.4",
"@vue/cli-service": "~4.4.4",
"@vue/compiler-sfc": "^3.0.0-beta.15",
"@vue/eslint-config-prettier": "^6.0.0",
"@vue/eslint-config-typescript": "^5.0.2",
"@vue/test-utils": "^2.0.0-alpha.6",
"eslint": "^7.3.0",
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-vue": "^7.0.0-alpha.6",
"fibers": "^5.0.0",
"lint-staged": "^10.2.10",
"node-sass": "^4.14.1",
"prettier": "^2.0.5",
"sass-loader": "^8.0.2",
"typescript": "~3.9.5",
"vue-cli-plugin-vue-next": "~0.1.3"
},

In App.vue

vue.config.js has unrelated configs - mainly sass and dev server configs 2 global define webpack booleans

What is expected?

Navigate between pages without errors with transitions

What is actually happening?

Two distinct errors are thrown upon further navigation


import {createApp} from 'vue';

Seems not to work in codesandbox
Below are copies from my browser's console

Link in pastebin because Github won't accept this long of a paste

https://pastebin.com/csqYFkWd

Hopefully the _leaveCb and parent node of null help you reproduce, it could be unrelated to vue or vue-router, but be something in transition handling?

Thank you very much for an awesome framework and I truly hope this helps.

@wucdbm
Copy link
Author

wucdbm commented Jun 19, 2020

I suspect it may be related to #1400 in a way.

Using mode out-in though.

@AlexandreBonaventure
Copy link
Contributor

This seems to be the same bug #1407
posva is saying the transition are not quite ready in vue-router

@underfin
Copy link
Member

@AlexandreBonaventure Have you an git repo for this? The codesandbox is un-convenient for debug this.

@posva
Copy link
Member

posva commented Jun 22, 2020

I tried out the code locally and it works just fine. That being said transitions still need a few things to support this (same as KeepAlive). See vuejs/rfcs#160

@posva posva closed this as completed Jun 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants