fix(runtime-core): use correct container for patch Teleport inside …
#1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
commented
Jul 25, 2020
| disabled.value = true | ||
| await nextTick() | ||
| expect(serializeInner(root)).toMatchInlineSnapshot( | ||
| `"<!--teleport start--><div>teleported</div><!--teleport end--><div>root</div>"` |
There was a problem hiding this comment.
This was fail in test, but I don‘t know why.The 250 line invoked, but the dom tree not update and not invoke the 260 code(and not throw errors in debug).
https://github.com/vuejs/vue-next/blob/6efb2fe3ea2586c2dae065c09de7039c2d46c509/packages/runtime-core/src/components/Teleport.ts#L248-L262
|
This failing test actually exposed some issues regarding the handling of Teleport children in block tree mode. The main reason is that its direct children needs to always inherit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…block tree
fix #1690